Skip to content

feat(dashmate): check system requirements before setup - #935

Merged
shuplenkov merged 7 commits into
v0.24-devfrom
feat/dashmate_check_requirements
Apr 19, 2023
Merged

feat(dashmate): check system requirements before setup#935
shuplenkov merged 7 commits into
v0.24-devfrom
feat/dashmate_check_requirements

Conversation

@shuplenkov

@shuplenkov shuplenkov commented Apr 19, 2023

Copy link
Copy Markdown

Issue being fixed or feature implemented

Need to check if everything installed (docker, docker-cmpose, etc.) before running setup command

What was done?

Setup command now check system requirements first

How Has This Been Tested?

Manual

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.24.0 milestone Apr 19, 2023
Comment thread packages/dashmate/src/docker/DockerCompose.js
Comment thread packages/dashmate/src/commands/setup.js Outdated
Comment thread packages/dashmate/src/commands/setup.js Outdated

@shumkov shumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov changed the title feat(dashamte): check system requirements before setup feat(dashmate): check system requirements before setup Apr 19, 2023
@shuplenkov
shuplenkov merged commit fbe062c into v0.24-dev Apr 19, 2023
@shuplenkov
shuplenkov deleted the feat/dashmate_check_requirements branch April 19, 2023 16:53
markin-io pushed a commit that referenced this pull request Apr 28, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants