Skip to content

fix(dash-spv): using WalletAccountCreationOptions::default() in the benchmark framework - #938

Merged
xdustinface merged 1 commit into
devfrom
fix/default-bench-wallet
Aug 10, 2026
Merged

fix(dash-spv): using WalletAccountCreationOptions::default() in the benchmark framework#938
xdustinface merged 1 commit into
devfrom
fix/default-bench-wallet

Conversation

@ZocoLini

@ZocoLini ZocoLini commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Wallet creation now uses standard default account settings, improving compatibility across supported wallet configurations.
    • Removed unnecessary restrictions tying each mnemonic to a specific account.

@ZocoLini
ZocoLini requested a review from xdustinface August 10, 2026 07:33
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 68a3b356-266d-4f11-8263-6b99aebfbd15

📥 Commits

Reviewing files that changed from the base of the PR and between b056d07 and e361e3e.

📒 Files selected for processing (1)
  • dash-spv-bench/src/main.rs

📝 Walkthrough

Walkthrough

The SPV benchmark now creates wallets with default WalletAccountCreationOptions. It removes the account-0-only helper and its unused BTreeSet import.

Changes

Wallet Creation

Layer / File(s) Summary
Use default wallet account options
dash-spv-bench/src/main.rs
Wallet creation now uses default account-creation options. The account-0-only helper and unused BTreeSet import were removed.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested labels: ready-for-review

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change to use WalletAccountCreationOptions::default() in the dash-spv benchmark.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/default-bench-wallet

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.17%. Comparing base (b056d07) to head (e361e3e).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #938      +/-   ##
==========================================
- Coverage   75.18%   75.17%   -0.02%     
==========================================
  Files         328      328              
  Lines       78194    78194              
==========================================
- Hits        58792    58784       -8     
- Misses      19402    19410       +8     
Flag Coverage Δ
core 77.29% <ø> (ø)
ffi 48.59% <ø> (+<0.01%) ⬆️
rpc 20.00% <ø> (ø)
spv 91.31% <ø> (-0.05%) ⬇️
wallet 76.88% <ø> (ø)
see 9 files with indirect coverage changes

@github-actions github-actions Bot added the ready-for-review CodeRabbit has approved this PR label Aug 10, 2026
@xdustinface
xdustinface merged commit d91ad05 into dev Aug 10, 2026
36 checks passed
@xdustinface
xdustinface deleted the fix/default-bench-wallet branch August 10, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review CodeRabbit has approved this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants