refactor(kvstore): merge e2e app with kvstore and support same-block execution#457
Merged
refactor(kvstore): merge e2e app with kvstore and support same-block execution#457
Conversation
lklimek
force-pushed
the
sbe-e2e-fixes
branch
from
be901dc to
bd8c943
Compare
lklimek
changed the title
lklimek
changed the title
lklimek
force-pushed
the
sbe-e2e-fixes
branch
from
4182483 to
f1c7111
Compare
As we add a tx to each block as part of vote extension logic, we break other tests.
* refactor: remove commit ABCI call
shotonoff
reviewed
Sep 21, 2022
Collaborator
shotonoff
left a comment
shotonoff
left a comment
There was a problem hiding this comment.
🚀 Great job! please have a look at the comments/suggestions
…d return error, refactor state store
This reverts commit a8cd027.
* fix: TestKVStoreKV, TestClientServer in kvstore_test.go * chore: remove Application.chainLockUpdate as unused functionality * chore: moved back chain-lock update to kvstore * chore: fix lint issues * fix: abci-client tests
* fix: replace state.LastCoreChainLockedBlockHeight with InitialCoreHeight * refactor: leave one save-validators-info
shotonoff
approved these changes
Sep 28, 2022
Collaborator
shotonoff
left a comment
shotonoff
left a comment
There was a problem hiding this comment.
🚀 Approved, left a few minor comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
E2e test application needs to support same-block execution. It includes, for example, support multiple of pending blocks provided to Prepare/ProcessProposal, that are committed with FinalizeBlock.
Example kvstore app needs to provide similar features. This leads to redundancy of the source code.
What was done?
How Has This Been Tested?
Breaking Changes
E2e app should be backwards-compatible.
Checklist:
For repository code-owners and collaborators only