Merged
Conversation
lklimek
approved these changes
Sep 26, 2022
Collaborator
lklimek
left a comment
lklimek
left a comment
There was a problem hiding this comment.
Please update PR description
lklimek
added a commit
that referenced
this pull request
Oct 4, 2022
…execution (#457) * fix(abci/types): panic in ValidatorSetUpdate.MarshalJSON() * refactor(kvstore): separate state from application * feat(kvstore): allow setting of persistence store and interval * feat(kvstore): app state can be marshaled to JSON (with DB content) * refactor(kvstore): merge kvstore with e2e app * chore: rewrite kvstore and e2e - "single" e2e test pass * fix(kvstore,e2e): kvstore state import breaks state * refactor(e2e): Move vote extension logic back to e2e app As we add a tx to each block as part of vote extension logic, we break other tests. * refactor(kvstore): self-review * test(consensus): fix invalid vote extension test * chore(e2e): re-add e2e app Rollback() to fix test * chore(kvstore): mv helpers.go helpers_test.go * test(kvstore): add snapshots test * refactor: remove abci commit call (#461) * refactor: remove commit ABCI call * fix(statesync): verify light block should use current height * refactor(kvstore): remove persistentkvstore app, rename New* funcs and return error, refactor state store * fix(kvstore): bytes.Buffer should be a pointer * chore: apply code review feedback * test(consensus): use t.Cleanup to rm test dir and cleanup state * chore(abci/types): fix val update json marshal returns nil on nil input * chore(kvstore): apply code review feedback * chore(consensus): fix build issues after merge * fix(state): correctly save validators at genesis * test(consensus): fix TestBlockReplayerReplay * Revert "fix(state): correctly save validators at genesis" This reverts commit a8cd027. * fix(consensus): validators from InitChain should replace genesis validators * fix(consensus): quorum type removed when processing initChain validators * test(rpc/client): minor test improvements * fix(state): last height validator changed handled incorrectly in initChain * chore(state): remove unused GetProcessProposalResponse * fix: some fixes after refactoring kvstore (#463) * fix: TestKVStoreKV, TestClientServer in kvstore_test.go * chore: remove Application.chainLockUpdate as unused functionality * chore: moved back chain-lock update to kvstore * chore: fix lint issues * fix: abci-client tests * fix: sbe unit tests (#464) * fix: replace state.LastCoreChainLockedBlockHeight with InitialCoreHeight * refactor: leave one save-validators-info * chore: minor code improvements based on feedback Co-authored-by: Dmitrii Golubev <shotonoff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Some unit-tests were broken by refactoring kvstore, this PR is fixed its
What was done?
Fix following tests:
How Has This Been Tested?
Tests
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only