fix(multimodal): fix UnsupportedOperationException for BigDecimal/BigInteger in message content - #255
Merged
Conversation
…Integer in message content (#250) JsonTreeWriter.jsonValue() throws UnsupportedOperationException, but MultiModalConversationParam.getInput() serializes messages via Gson.toJsonTree(), so a BigDecimal/BigInteger value (e.g. fps) in message content crashed the request before sending. Regression introduced by #244 in v2.22.25. Write numbers with value(Number) and serialize fallback objects directly into the writer instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MultiModalMessageAdapter.writeValue()usedJsonWriter.jsonValue()forBigDecimal/BigIntegervalues and the unsupported-type fallback, butMultiModalConversationParam.getInput()serializes messages viaGson.toJsonTree(), whoseJsonTreeWriter.jsonValue()throwsUnsupportedOperationException— crashing requests (e.g. aBigDecimalfpsin video content) before sendingvalue(Number)(unquoted, JsonTreeWriter-safe) and serialize fallback objects directly into the writer viagson.toJson(value, type, out)Test plan
TestMultiModalMessageAdapter(3 cases): BigDecimal/BigInteger and fallback object through thetoJsonTreepath, plus the streaming-writer path