[DF] use datafusion 9956f80f197550051db7debae15d5c706afc22a3 #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
requested review from
ayushdg,
galipremsagar and
jdye64
as code owners
andygrove
commented
Aug 8, 2022
| use core::iter::Peekable; | ||
| use core::str::Chars; | ||
| use sqlparser::dialect::Dialect; | ||
| use datafusion_sql::sqlparser::dialect::Dialect; |
Contributor
Author
There was a problem hiding this comment.
We can use the version of sqlparser re-exported by DataFusion rather than manage this dependency ourselves
jdye64
approved these changes
Aug 8, 2022
Collaborator
jdye64
left a comment
jdye64
left a comment
There was a problem hiding this comment.
Thanks for the version bump Andy!
Codecov Report
@@ Coverage Diff @@
## datafusion-sql-planner #667 +/- ##
=========================================================
Coverage ? 66.97%
=========================================================
Files ? 73
Lines ? 3637
Branches ? 753
=========================================================
Hits ? 2436
Misses ? 1055
Partials ? 146 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
|
@andygrove we had some upstream CI issues. Could you merge that latest upstream/datafusion-sql-planner and push again? I think that should sort out the CI build |
andygrove
changed the title
Contributor
Author
|
@jdye64 upmerged and bumped the versions again - note there is a change to decimal 128/256 support now |
andygrove
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to the latest version of DataFusion and Arrow.
Changes:
DataTypes::Decimalwas renamed toDecimal128andDecimal256was added, and these are now both supported here