Skip to content

OAR: add async to _submit_job method #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesteve merged 2 commits into from
Feb 5, 2020
Merged

OAR: add async to _submit_job method #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b4c49a
OAR: add async to _submit_job method
msimonin Feb 5, 2020
f934d42
Add changelog entry.
lesteve Feb 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dask_jobqueue/oar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def __init__(

logger.debug("Job script: \n %s" % self.job_script())

def _submit_job(self, fn):
async def _submit_job(self, fn):
# OAR specificity: the submission script needs to exist on the worker
# when the job starts on the worker. This is different from other
# schedulers that only need the script on the submission node at
Expand Down
5 changes: 3 additions & 2 deletions docs/source/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Changelog
=========

Devlopment version
------------------
Development version
-------------------

- ``LSFCluster``: add ``use_stdin`` to ``LSFCluster``. This switches between
``bsub < job_script`` and ``bsub job_script`` to launch a ``LSF`` job
Expand All @@ -13,6 +13,7 @@ Devlopment version
``processes ~= sqrt(cores)`` so that the number of processes and the number
of threads per process is roughly the same. Old default was to use one
process and only threads, i.e. ``proccesses=1``, ``threads_per_process=cores``.
- fix bug (forgotten async def) in ``OARCluster._submit_job`` (:pr:`380`).

0.7.0 / 2019-10-09
------------------
Expand Down