Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpack/repack orderedDict #4623

Merged
merged 3 commits into from Mar 21, 2019

Conversation

Projects
None yet
4 participants
@justinwp
Copy link
Contributor

commented Mar 21, 2019

  • Tests added / passed
  • Passes flake8 dask

@justinwp justinwp force-pushed the justinwp:feat/unpack_repack_ordered_dict branch from d7fe2c1 to 707610d Mar 21, 2019

@justinwp justinwp force-pushed the justinwp:feat/unpack_repack_ordered_dict branch from 707610d to 49160cc Mar 21, 2019

@mrocklin

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

cc @jcrist

Show resolved Hide resolved dask/base.py Outdated
@jcrist

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Draft PRs are new to me, looks like they were added a month ago (reference for others): https://github.blog/2019-02-14-introducing-draft-pull-requests/

@justinwp

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

Draft PRs are new to me, looks like they were added a month ago (reference for others): https://github.blog/2019-02-14-introducing-draft-pull-requests/

My typical use has been to leave in draft until I get CI passing unless it is sufficiently complex to warrant review earlier.

@jrbourbeau

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

FWIW just as a side note, draft PRs don't currently trigger Travis CI builds (although it appears there's some internal discussion about if they want to change this https://travis-ci.community/t/draft-pull-requests-not-being-built/2434)

@justinwp justinwp marked this pull request as ready for review Mar 21, 2019

@jcrist

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

LGTM. Thanks @justinwp.

@jcrist jcrist merged commit 1859263 into dask:master Mar 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jrbourbeau

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Thanks @justinwp. I noticed this was your first code contribution to Dask, welcome!

asmith26 added a commit to asmith26/dask that referenced this pull request Apr 22, 2019

unpack/repack orderedDict (dask#4623)
* orderedDict

* switch list to tuple

* flake8 fix

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

unpack/repack orderedDict (dask#4623)
* orderedDict

* switch list to tuple

* flake8 fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.