Skip to content

unpack/repack orderedDict#4623

Merged
jcrist merged 3 commits intodask:masterfrom
jpoehnelt:feat/unpack_repack_ordered_dict
Mar 21, 2019
Merged

unpack/repack orderedDict#4623
jcrist merged 3 commits intodask:masterfrom
jpoehnelt:feat/unpack_repack_ordered_dict

Conversation

@jpoehnelt
Copy link
Copy Markdown
Contributor

@jpoehnelt jpoehnelt commented Mar 21, 2019 •
edited
Loading

  • Tests added / passed
  • Passes flake8 dask

@mrocklin
Copy link
Copy Markdown
Member

mrocklin commented Mar 21, 2019

cc @jcrist

jcrist
jcrist reviewed Mar 21, 2019
View reviewed changes
@jcrist
Copy link
Copy Markdown
Member

jcrist commented Mar 21, 2019

Draft PRs are new to me, looks like they were added a month ago (reference for others): https://github.blog/2019-02-14-introducing-draft-pull-requests/

@jpoehnelt
Copy link
Copy Markdown
Contributor Author

jpoehnelt commented Mar 21, 2019

Draft PRs are new to me, looks like they were added a month ago (reference for others): https://github.blog/2019-02-14-introducing-draft-pull-requests/

My typical use has been to leave in draft until I get CI passing unless it is sufficiently complex to warrant review earlier.

@jrbourbeau
Copy link
Copy Markdown
Member

jrbourbeau commented Mar 21, 2019

FWIW just as a side note, draft PRs don't currently trigger Travis CI builds (although it appears there's some internal discussion about if they want to change this https://travis-ci.community/t/draft-pull-requests-not-being-built/2434)

@jpoehnelt jpoehnelt marked this pull request as ready for review March 21, 2019 16:36
@jcrist
Copy link
Copy Markdown
Member

jcrist commented Mar 21, 2019

LGTM. Thanks @JustinWP.

@jcrist jcrist merged commit 1859263 into dask:master Mar 21, 2019
@jrbourbeau
Copy link
Copy Markdown
Member

jrbourbeau commented Mar 21, 2019

Thanks @JustinWP. I noticed this was your first code contribution to Dask, welcome!

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019
@jpoehnelt
unpack/repack orderedDict (dask#4623)
410517a 
* orderedDict

* switch list to tuple

* flake8 fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcrist jcrist jcrist left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpoehnelt @mrocklin @jcrist @jrbourbeau