Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated diagnostic bokeh test for compatibility with bokeh>=1.1.0 #4680

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

commented Apr 9, 2019

Fixes regression in profiler tests with bokeh >=1.1.0 due to a change in the way grids of plots are represented. Also checked that the plot still displays as expected:

Screen Shot 2019-04-09 at 7 26 17 PM

  • Tests added / passed
  • Passes flake8 dask
@jcrist

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Thanks @philippjfr! Looks good to me, will merge on tests passing.

@martindurant martindurant referenced this pull request Apr 9, 2019

Merged

fix ordering of quantiles in describe. #4647

2 of 2 tasks complete

@jcrist jcrist merged commit 4c9d28a into dask:master Apr 9, 2019

3 checks passed

codecov/project 91.24% (target 90%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.