Fix for #5448: Correct chunk size logic in map_overlap for asymmetric overlaps#5449
Merged
mrocklin merged 1 commit intodask:masterfrom Oct 4, 2019
Merged
Conversation
benjeffery
changed the title
map_overlap for asymmetric overlaps
benjeffery
changed the title
map_overlap for asymmetric overlapsmap_overlap for asymmetric overlaps
Member
|
This looks good to me. Thank you for identifying this issue, for tracking it down, and for submitting a concise solution. Merging in. I also notice that this is your first code contribution to this repository. Welcome! |
Contributor
Author
|
Thanks for the merge and for dask! We met in Oxford quite a few years ago when dask was just getting started, it's been great to see it grow. |
Member
Amen to that. Thanks for chipping in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5448
I've modified the test for this code as I think it was incorrect. Would appreciate another pair of eyes on it though.
black dask/flake8 dask