Resolve sqlalchemy import failures in mindeps testing#9809
Merged
Resolve sqlalchemy import failures in mindeps testing#9809
sqlalchemy import failures in mindeps testing#9809Conversation
graingert
reviewed
Jan 5, 2023
3 tasks
Member
|
I wonder if it would be better to use an alias like and setting the warning to |
Member
|
This is looking good so far. Thank you @charlesbluca and @graingert . The current failure is listed at #9793 (which we should also resolve ASAP) Merging. |
jrbourbeau
reviewed
Jan 9, 2023
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
We're seeing
09:15:35 ERROR: while parsing the following warning configuration:
09:15:35
09:15:35 ignore:.*:dask.tests.warning_aliases.RemovedIn20Warning
09:15:35
09:15:35 This error occurred:
09:15:35
09:15:35 Traceback (most recent call last):
09:15:35 File "/opt/conda/envs/dask/lib/python3.9/site-packages/_pytest/config/__init__.py", line 1690, in parse_warning_filter
09:15:35 category: Type[Warning] = _resolve_warning_category(category_)
09:15:35 File "/opt/conda/envs/dask/lib/python3.9/site-packages/_pytest/config/__init__.py", line 1728, in _resolve_warning_category
09:15:35 m = __import__(module, None, None, [klass])
09:15:35 ModuleNotFoundError: No module named 'dask.tests.warning_aliases'
failing in the gpuCI here. @charlesbluca @graingert any thoughts on why that may be?
Member
Author
|
Think the issue here is that the gpuCI build is running |
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9801 added a warning filter for
sqlalchemy.exc.RemovedIn20Warningthat referred to the module directly, raising failures in our mindeps testing sincesqlalchemyis not installed in that environment.This PR modifies the warning filter to match for the warning using regex, which doesn't require
sqlalchemyto be installed and resolves the mindeps failures.cc @graingert
pre-commit run --all-files