[WIP] Fix dask.config dict usage in favor of config object interface#2442
Open
djhoese wants to merge 1 commit into
Open
[WIP] Fix dask.config dict usage in favor of config object interface#2442djhoese wants to merge 1 commit into
djhoese wants to merge 1 commit into
Conversation
Author
|
@mrocklin What is your (and other dask devs) preferred way of handling circular dependency releases between dask packages? For example, dask/dask#4328 is failing because distributed expects to use the I could modify Thoughts? |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR goes along with dask/dask#4328 (or its predecessor dask/dask#4099).
It was discussed in related issues that it would be best if dask used a configuration object instead of the global config module in
dask/config.py. I started doing this in 4099 and then ended up creating a separate config package nameddonfigwhich is what 4328 uses. The only failing tests remaining for me locally were related to thedistributedpackage and its use ofdask/config.py:config; the internal dictionary representing the configuration.This PR shows one way of working around the transition from internal dict to public config object. I couldn't really think of a better solution. New versions of
donfigsupport thex in configusage, but old dask config doesn't so it just makes the code ugly.TODO: Need to fix up tests and find the easiest way to present these changes for the dask devs.