Replace gen.TimeoutError with utils.TimeoutError#3394
Merged
jrbourbeau merged 4 commits intodask:masterfrom Jan 21, 2020
Merged
Replace gen.TimeoutError with utils.TimeoutError#3394jrbourbeau merged 4 commits intodask:masterfrom
jrbourbeau merged 4 commits intodask:masterfrom
Conversation
Previously we had a mix of gen.TimeoutError and asyncio.TimeoutError within the code. This import asyncio.TimeoutError within utils.py (and our top level imports) and then uses that consistently throughout the codebase
Member
|
Thanks for the PR @mrocklin, I think this is moving in the right direction. My initial thought is that since I'm out of the office today but will give this a more thorough look later this evening or tomorrow |
Sometimes when we use Tornado objects like events and queues we experience gen.TimeoutErrors. In these cases we raise instead asyncio.TimeoutErrors
mrocklin
force-pushed
the
asyncio-timeout
branch
from
a0b7a19 to
8b78b86
Compare
Member
Author
|
@jrbourbeau ok to merge? cc also @jcrist |
Member
|
Thanks @mrocklin, taking a look at the changes right now |
jrbourbeau
approved these changes
Jan 21, 2020
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks for going through and making all these TimeoutError replacements! The changes here LGTM
bnaul
pushed a commit
to replicahq/distributed
that referenced
this pull request
Feb 10, 2020
* Replace gen.TimeoutError with utils.TimeoutError Previously we had a mix of gen.TimeoutError and asyncio.TimeoutError within the code. This import asyncio.TimeoutError within utils.py (and our top level imports) and then uses that consistently throughout the codebase * Translate gen.TimeoutErrors into asyncio.TimeoutErrors Sometimes when we use Tornado objects like events and queues we experience gen.TimeoutErrors. In these cases we raise instead asyncio.TimeoutErrors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we had a mix of gen.TimeoutError and asyncio.TimeoutError
within the code. This import asyncio.TimeoutError within utils.py (and
our top level imports) and then uses that consistently throughout the
codebase
cc @jrbourbeau
(disclaimer, I haven't yet fully tested this, so this may still need some love)