Improved format handling for the REST /api/rows and /api/changes#214
Merged
max-mapper merged 15 commits intodat-ecosystem:masterfrom Dec 4, 2014
Merged
Improved format handling for the REST /api/rows and /api/changes#214max-mapper merged 15 commits intodat-ecosystem:masterfrom
max-mapper merged 15 commits intodat-ecosystem:masterfrom
Conversation
finnp
changed the title
Contributor
Author
|
I added format options for /api/changes and created some tests. The /api/changes feed now defaults to json, however if |
Collaborator
|
yeah i think that makes sense |
The test takes about 7 seconds on my machine..
Contributor
Author
|
I added a few more tests and I think it's ready to be reviewed/merged now. |
Collaborator
|
i used the new version and added you as an owner! |
Collaborator
|
oops wrong issue. i was talking about the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just my WIP PR, which also will fail the tests until max-mapper/csv-write-stream#14 is merged and the data-format module is updated. It relates to bug #210
What this tries to achieve is having the exact same options for the REST api /api/rows endpoint as for createReadStream concerning the
formatoption. Therefore I moved all formatting in its own module.I also wanted to allow users to use accept headers, but that's the messy part in
lib/format.js. There I am trying to map formats to mediatypes. Also I don't want to break the existing APIs. But maybe that is something worth doing?/cc @Karissa