Merged
Conversation
Collaborator
Author
|
published as 0.2.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I just took some time to actually understand to how the module works...
And the problem I was having in #13 was quite simply due to arrays as values. What happened whas that the
'(/['+sep+'\\r\\n"]/.test('+prop+')part always was true on the implicit to string conversion of array properties (since[1,2].toString()contains a comma :D).Just turning the property to a string solves it and doesn't seem to add time to the benchmark on my computer (
+""seems to be faster the.toString())I also added a test for it. It would probably also be cool to add a
jsonMode, which would actually stringify those array and object properties correctly.Best,
Finn