Skip to content

add --tsv import/export option to cli#232

Merged
max-mapper merged 4 commits intodat-ecosystem:masterfrom
ekg:master
Dec 4, 2014
Merged

add --tsv import/export option to cli#232
max-mapper merged 4 commits intodat-ecosystem:masterfrom
ekg:master

Conversation

@ekg
Copy link
Copy Markdown
Contributor

@ekg ekg commented Dec 3, 2014

Instead of --csv --separator=$'\t', simply specify --tsv. The same works for both import and export. This includes tests for csv and tsv stdin import.

joyrexus and others added 3 commits December 2, 2014 15:24
Tab-separated tables (.tsv) are really common in unix-based informatics
pipelines. Adding a --tsv cli option makes it much simpler to pipe in and out
tab-separated data.
@ekg ekg mentioned this pull request Dec 3, 2014
@max-mapper
Copy link
Copy Markdown
Collaborator

@ekg I merged #229 first, and now I get conflicts w/ this one. I don't wanna mess up anything, so would you mind rebasing this against dat@master?

@ekg
Copy link
Copy Markdown
Contributor Author

ekg commented Dec 4, 2014

Will do.
On Dec 4, 2014 12:44 AM, "Max Ogden" notifications@github.com wrote:

@ekg https://github.com/ekg I merged #229
#229 first, and now I get conflicts
w/ this one. I don't wanna mess up anything, so would you mind rebasing
this against dat@master?


Reply to this email directly or view it on GitHub
#232 (comment).

Resolve conflicts due to basing this on another PR.

Conflicts:
	bin/import.js
	lib/commands.js
	test/tests/cli.js
@ekg
Copy link
Copy Markdown
Contributor Author

ekg commented Dec 4, 2014

Done. Tests pass locally. We'll see what Mr. Travis says.

max-mapper added a commit that referenced this pull request Dec 4, 2014
add --tsv import/export option to cli
@max-mapper max-mapper merged commit c339a76 into dat-ecosystem:master Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants