Skip to content

ENH: add nanmin#804

Merged
lucascolley merged 10 commits into
data-apis:mainfrom
OmarManzoor:nan_reductions
Jul 13, 2026
Merged

ENH: add nanmin#804
lucascolley merged 10 commits into
data-apis:mainfrom
OmarManzoor:nan_reductions

Conversation

@OmarManzoor

@OmarManzoor OmarManzoor commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Towards: #789

  • Adds array API support for nanmin

@OmarManzoor

OmarManzoor commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

@lucascolley I added one of these for a start. I think after we finalize one of them the others can follow along.

@lucascolley lucascolley self-requested a review June 16, 2026 17:07
@lucascolley lucascolley added enhancement New feature or request new function labels Jun 16, 2026
@lucascolley lucascolley added this to the 0.11.1 milestone Jun 26, 2026
lucascolley
lucascolley reviewed Jun 29, 2026
View reviewed changes

@lucascolley lucascolley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few merge conflicts

Comment thread src/array_api_extra/_lib/_funcs.py
@lucascolley lucascolley self-requested a review June 30, 2026 18:35
lucascolley
lucascolley reviewed Jul 7, 2026
View reviewed changes
Comment thread src/array_api_extra/_delegation.py Outdated
Comment thread src/array_api_extra/_delegation.py
Comment thread tests/test_funcs.py
Comment thread tests/test_funcs.py Outdated
@OmarManzoor

OmarManzoor commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@lucascolley Does this look fine to merge?

@lucascolley lucascolley self-requested a review July 13, 2026 07:49
lucascolley
lucascolley reviewed Jul 13, 2026
View reviewed changes
Comment thread tests/test_funcs.py
lucascolley
lucascolley approved these changes Jul 13, 2026
View reviewed changes

@lucascolley lucascolley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Omar! nice work

@lucascolley

lucascolley commented Jul 13, 2026

Copy link
Copy Markdown
Member

I think we should test this out in scikit-learn before adding more of these nan functions here, btw

@lucascolley lucascolley merged commit dcd9242 into data-apis:main Jul 13, 2026
13 checks passed
@OmarManzoor OmarManzoor deleted the nan_reductions branch July 13, 2026 12:22
@OmarManzoor

OmarManzoor commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

I think we should test this out in scikit-learn before adding more of these nan functions here, btw

Maybe we can add nanmax as well and then test these two out together? What do you think? I think they are quite similar.

@lucascolley

lucascolley commented Jul 13, 2026

Copy link
Copy Markdown
Member

I think we should test this out in scikit-learn before adding more of these nan functions here, btw

Maybe we can add nanmax as well and then test these two out together? What do you think? I think they are quite similar.

feel free to start working on a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucascolley lucascolley lucascolley approved these changes
+1 more reviewer
@betatim betatim betatim left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request new function

Projects

None yet

Milestone

0.11.1

Development

Successfully merging this pull request may close these issues.

3 participants

@OmarManzoor @lucascolley @betatim