Skip to content

MAINT: test_eye: limit the range of k#444

Merged
lucascolley merged 1 commit into
data-apis:masterfrom
ev-br:eye_limit_k
Jul 23, 2026
Merged

MAINT: test_eye: limit the range of k#444
lucascolley merged 1 commit into
data-apis:masterfrom
ev-br:eye_limit_k

Conversation

@ev-br

@ev-br ev-br commented Jul 23, 2026

Copy link
Copy Markdown
Member

Limit the range of the k variable in testing eye(n_rows, n_cols, k) to avoid using completely bogus values. Caught in
data-apis/array-api-compat#452:

Large valid diagonal offsets such as k=2147483648 overflow or fail MLX’s argument binding.

@lucascolley
lucascolley merged commit 65bd900 into data-apis:master Jul 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants