Skip to content

[V2] breaking(renderer): remove component types with -field affix. - #350

Merged
rvsia merged 1 commit into
v2from
remove-field-affix
Mar 3, 2020
Merged

[V2] breaking(renderer): remove component types with -field affix.#350
rvsia merged 1 commit into
v2from
remove-field-affix

Conversation

@Hyperkid123

Copy link
Copy Markdown
Member

No description provided.

@Hyperkid123 Hyperkid123 added renderer React form renderer PR V2 labels Mar 3, 2020
@Hyperkid123
Hyperkid123 requested a review from rvsia March 3, 2020 13:38
@codecov

codecov Bot commented Mar 3, 2020

Copy link
Copy Markdown

Codecov Report

Merging #350 into v2 will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2     #350   +/-   ##
=======================================
  Coverage   86.46%   86.46%           
=======================================
  Files         127      127           
  Lines        2025     2025           
  Branches      649      649           
=======================================
  Hits         1751     1751           
  Misses        274      274           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e54ea76...2a73574. Read the comment docs.

@Hyperkid123 Hyperkid123 changed the title breaking(renderer): remove component types with -field affix. [V2] breaking(renderer): remove component types with -field affix. Mar 3, 2020

@rvsia rvsia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪 🇨🇰

@Hyperkid123

Copy link
Copy Markdown
Member Author

demo died

@rvsia

rvsia commented Mar 3, 2020

Copy link
Copy Markdown
Contributor

Please do not forget to update the migration guide! 🔖 📖

@Hyperkid123

Hyperkid123 commented Mar 3, 2020

Copy link
Copy Markdown
Member Author

I think the demo might be broken until we release a new version of the renderer

got it

@rvsia
rvsia merged commit 2ca49cf into v2 Mar 3, 2020
@Hyperkid123
Hyperkid123 deleted the remove-field-affix branch March 3, 2020 14:26
@Hyperkid123

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 1.31.0 🎉

The release is available on

Demo can be found here!

@Hyperkid123

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 2.0.0 🎉

The release is available on

Demo can be found here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released renderer React form renderer PR V2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants