feat(lib-vuetify): add realtime websocket to notification queue#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate the realtime notification queue (proven in data-fair's local fork) into the shared
@data-fair/lib-vuetify-eventslib so data-fair and portals share one source.DfNotificationQueue.vue: subscribe touser:<id>:notificationsover WebSocket (@data-fair/lib-vue/ws) and prepend pushed notifications live;refresh(size)reloads the list on menu open and only refreshes the unread count on close.eventsUrlprop now means the events service root: REST hits${eventsUrl}/api/notificationsand the WS connects to${eventsUrl}/api/(same base as REST, so it reaches the API/ws-server even in split UI/API topologies).sendertyped asEmitter(adds@data-fair/lib-common-typespeer dependency).dev.vuepasses the new$eventsUrl(service root) instead of$apiPath.Why: the realtime version only lived in data-fair's local fork (which overrode this lib via a vite alias); portals carried a separate static fork. This makes the lib the single canonical source.
Regression risks:
eventsUrlmust now be the events service root (not the/apibase), and consumers must route/events/api/to the events service. Verified end-to-end in data-fair and portals — realtime push works through nginx with no extra config.@data-fair/lib-common-typespeer dependency; consumers must provide it.0.3.0release is a separate follow-up commit on main.