feat(partners): drop partner contact email after invitation workflow#134
Merged
Conversation
The partner contactEmail is only needed during the invitation workflow. Remove it once a partnership is established (on accept and in the superadmin _create path), make it optional in the schema, and add a migration that strips it from existing established partnerships. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop persisting the partner
contactEmailonce it is no longer needed.What changed:
contactEmailwhen a partner invitation is accepted (validatePartner).contactEmailfor superadmin-created established partnerships (_create); drop it from that endpoint's request schema and the superadmin UI.contactEmailoptional in thePartnerschema (pending invitations still carry it).upgrade/8.20.1/remove-established-partner-emails.tsto strip it from existing established partnerships.Why: the email is only used during the invitation workflow; keeping it afterward is unnecessary personal information that goes stale over time.
Heads-up: the migration permanently removes the field from established partners (idempotent);
/partners/_createnow rejects acontactEmailbody field (superadmin-only, sole caller updated).