feat: do not throw an error if it appears in a short-circuited branch. #10439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
What happen panic(select if(1== 1, 1 / 0, 1 / 1))? |
Contributor
Author
|
RinChanNOWWW
force-pushed
the
catch
branch
2 times, most recently
from
2745a7f to
3be3b5a
Compare
RinChanNOWWW
requested review from
andylokandy and
sundy-li
and removed request for
andylokandy
Member
|
@mergify update |
Contributor
✅ Branch has been successfully updated |
sundy-li
approved these changes
Mar 10, 2023
andylokandy
approved these changes
Mar 12, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Add a new
Expr:Expr::Catch.case whenclause,if, andmulti_if's branches will be wrapped inExpr::Catch.Expr::Catchwill catch the error and returnTuple<T, String NULL>which contains evaluation results and the error messages (maybe not exists).The error will be thrown only if it appears in the activated branch.
Closes #10409