Skip to content

Conversation

@wangjili8417
Copy link

@wangjili8417 wangjili8417 commented Mar 12, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

The modification method is to delete the matching in MySQL Federated, and instead judge the type of the client in the version function to return the corresponding version information. Clickhouse Federated is also a similar problem, which has been changed by the way.

Closes #10342

@vercel
Copy link

vercel bot commented Mar 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Mar 12, 2023 at 2:56PM (UTC)

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Mar 12, 2023
@BohuTANG BohuTANG requested a review from TCeason March 12, 2023 08:53
@TCeason
Copy link
Collaborator

TCeason commented Mar 12, 2023

Please add some test in sql logic

@TCeason
Copy link
Collaborator

TCeason commented Mar 12, 2023

Like this file tests/sqllogictests/suites/query/case_sensitivity/system_table.test,

onlyif mysql
query I
select "Engine" as engine from system.engines order by engine
----
FUSE
MEMORY
NULL
RANDOM
VIEW

This select query will only check under mysql handler.

@TCeason TCeason requested a review from b41sh March 12, 2023 12:58
@BohuTANG
Copy link
Member

Diff in /workspace/src/query/service/tests/it/servers/mysql/mysql_federated.rs at line 27:
         assert!(result.is_none());
     }
 
-
     // variables
     {
         let query = "select @@tx_isolation, @@session.tx_isolation";
Error: Process completed with exit code 1.

@mergify mergify bot merged commit 7c2bcff into databendlabs:main Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the function version() has some problem

4 participants