Skip to content

[store] feature: reopen a MetaStore#1066

Merged
databend-bot merged 2 commits into
databendlabs:masterfrom
drmingdrmer:open-meta-store
Jul 16, 2021
Merged

[store] feature: reopen a MetaStore#1066
databend-bot merged 2 commits into
databendlabs:masterfrom
drmingdrmer:open-meta-store

Conversation

@drmingdrmer

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

[store] refactor: clean up todo
[store] feature: reopen a MetaStore

MetaStore is the store of a raft node.
In this commit it oly impl RaftState reopen. Log and state machine are
still pure in-memory impl.

Changelog

  • New Feature

  • Improvement

Related Issues

#271

MetaStore is the store of a raft node.
In this commit it oly impl RaftState reopen. Log and state machine are
still pure in-memory impl.
@databend-bot databend-bot added pr-feature this PR introduces a new feature to the codebase pr-improvement labels Jul 16, 2021
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1066 (bc1117e) into master (2fbe079) will increase coverage by 4%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1066     +/-   ##
========================================
+ Coverage      58%     62%     +4%     
========================================
  Files         410     391     -19     
  Lines       21832   20299   -1533     
========================================
- Hits        12777   12773      -4     
+ Misses       9055    7526   -1529     
Impacted Files Coverage Δ
fusestore/store/src/meta_service/raftmeta.rs 0% <ø> (ø)
common/runtime/src/runtime_test.rs 66% <0%> (-27%) ⬇️
fusestore/store/src/configs/config.rs 0% <0%> (ø)
fusestore/store/src/api/rpc_service.rs 0% <0%> (ø)
fusestore/store/src/meta_service/raft_state.rs 0% <0%> (ø)
fusestore/store/src/meta_service/state_machine.rs 0% <0%> (ø)
fusestore/store/src/meta_service/applied_state.rs
fusestore/store/src/executor/meta_handlers.rs
fusestore/store/src/meta_service/placement.rs
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fbe079...bc1117e. Read the comment docs.

@drmingdrmer drmingdrmer changed the title [store] refactor: clean up todo [store] feature: reopen a MetaStore Jul 16, 2021
@drmingdrmer
drmingdrmer marked this pull request as ready for review July 16, 2021 18:35
@drmingdrmer drmingdrmer added this to the v0.5 milestone Jul 16, 2021

@ariesdevil ariesdevil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@databend-bot

Copy link
Copy Markdown
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
databend-bot merged commit 0264cd2 into databendlabs:master Jul 16, 2021
@drmingdrmer

Copy link
Copy Markdown
Member Author

LGTM

Thank you man!

@drmingdrmer
drmingdrmer deleted the open-meta-store branch July 16, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants