Skip to content

Conversation

@RinChanNOWWW
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Closes #10953

@RinChanNOWWW RinChanNOWWW requested review from b41sh and sundy-li April 6, 2023 08:53
@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Apr 6, 2023 9:47am

@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2023

This pull request's title is not fulfill the requirements. @RinChanNOWWW please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@RinChanNOWWW RinChanNOWWW changed the title Fix: fix fixed_hash for Decimal types. fix: fix fixed_hash for Decimal types. Apr 6, 2023
@RinChanNOWWW RinChanNOWWW changed the title fix: fix fixed_hash for Decimal types. fix: fixed_hash supports Decimal types. Apr 6, 2023
@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Apr 6, 2023
@RinChanNOWWW
Copy link
Contributor Author

We can abstract the marshalling of large-sized integers (i128,u128,i256,u256) by databendlabs/opensrv#45.

They are marshlled manually in thie PR.

@mergify mergify bot merged commit dc00b2a into databendlabs:main Apr 6, 2023
@RinChanNOWWW RinChanNOWWW deleted the decimal-hash branch April 24, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: group by decimal failed.

3 participants