Skip to content

add TLS support for http api#1140

Merged
bohutang merged 2 commits into
databendlabs:masterfrom
bohutang:dev-api-tls-1136
Jul 23, 2021
Merged

add TLS support for http api#1140
bohutang merged 2 commits into
databendlabs:masterfrom
bohutang:dev-api-tls-1136

Conversation

@bohutang

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

add TLS support for http api

Changelog

  • Improvement

Related Issues

Fixes #1136

Test Plan

Unit Tests

Stateless Tests

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot

Copy link
Copy Markdown
Member

Hello @bohutang, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

@bohutang
bohutang requested a review from ZhiHanZ July 21, 2021 09:03
@bohutang

Copy link
Copy Markdown
Member Author

Ping @ZhiHanZ for review 👯

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1140 (5e5e9b1) into master (dcc45ae) will decrease coverage by 1%.
The diff coverage is 25%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1140    +/-   ##
=======================================
- Coverage      68%     67%    -2%     
=======================================
  Files         434     429     -5     
  Lines       24692   24373   -319     
=======================================
- Hits        17006   16458   -548     
- Misses       7686    7915   +229     
Impacted Files Coverage Δ
fusequery/query/src/api/http_service.rs 0% <0%> (ø)
fusequery/query/src/configs/config.rs 64% <71%> (+4%) ⬆️
fusequery/query/src/configs/config_test.rs 62% <100%> (-3%) ⬇️
common/datavalues/src/arrays/ops/agg.rs 30% <0%> (-41%) ⬇️
common/datavalues/src/arrays/ops/apply.rs 63% <0%> (-27%) ⬇️
common/datavalues/src/arrays/upstream_traits.rs 16% <0%> (-23%) ⬇️
fusestore/store/src/engine/mem_engine.rs 72% <0%> (-21%) ⬇️
common/datavalues/src/arrays/kernels/take.rs 7% <0%> (-19%) ⬇️
common/datavalues/src/arrays/builders/builder.rs 23% <0%> (-17%) ⬇️
common/datavalues/src/arrays/kernels/iterator.rs 22% <0%> (-17%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc45ae...5e5e9b1. Read the comment docs.

@bohutang
bohutang merged commit ff4e51a into databendlabs:master Jul 23, 2021
@bohutang
bohutang deleted the dev-api-tls-1136 branch July 23, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[security] Http api TLS support

4 participants