Skip to content

[fix] remove the unused module#1165

Merged
databend-bot merged 1 commit into
databendlabs:masterfrom
zhyass:feature_if
Jul 23, 2021
Merged

[fix] remove the unused module#1165
databend-bot merged 1 commit into
databendlabs:masterfrom
zhyass:feature_if

Conversation

@zhyass

@zhyass zhyass commented Jul 23, 2021

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

I get some warnings in vscode, so I try to fix it by remove the unused module.

module `session_ref` is private  private module
unused import: `fuse_query::servers::MySQLConnection`\n\nnote: `#[warn(unused_imports)]` on by default

Changelog

  • Bug Fix

Related Issues

@databend-bot databend-bot added the pr-bugfix this PR patches a bug in codebase label Jul 23, 2021
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot

Copy link
Copy Markdown
Member

Hello @zhyass, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1165 (30bee0c) into master (3db2d25) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1165    +/-   ##
=======================================
  Coverage      70%     70%            
=======================================
  Files         441     443     +2     
  Lines       25694   26041   +347     
=======================================
+ Hits        18078   18404   +326     
- Misses       7616    7637    +21     
Impacted Files Coverage Δ
common/runtime/src/runtime_test.rs 53% <0%> (-21%) ⬇️
fusestore/store/src/meta_service/sled_tree.rs 92% <0%> (ø)
fusestore/store/src/meta_service/sled_tree_test.rs 96% <0%> (ø)
fusestore/store/src/meta_service/raft_log.rs 97% <0%> (+<1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db2d25...30bee0c. Read the comment docs.

@databend-bot

Copy link
Copy Markdown
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
databend-bot merged commit c638920 into databendlabs:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants