Skip to content

bug fix: clean data parts while dropping database#1208

Merged
databend-bot merged 2 commits into
databendlabs:masterfrom
zhyass:feature_if
Jul 28, 2021
Merged

bug fix: clean data parts while dropping database#1208
databend-bot merged 2 commits into
databendlabs:masterfrom
zhyass:feature_if

Conversation

@zhyass

@zhyass zhyass commented Jul 28, 2021

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

Cleans dataparts metadata when dropping remote database

Changelog

  • Bug Fix

Related Issues

Fixes #1207

Test Plan

Stateless Tests

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot databend-bot added the pr-bugfix this PR patches a bug in codebase label Jul 28, 2021
@databend-bot

Copy link
Copy Markdown
Member

Hello @zhyass, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

@bohutang bohutang assigned dantengsky and unassigned dantengsky Jul 28, 2021
@bohutang
bohutang requested a review from dantengsky July 28, 2021 03:07
None => Err(ErrorCode::UnknownTable(_table_name)),
None => Err(ErrorCode::UnknownTable(format!(
"Unknown table: '{}'",
_table_name

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe _table_name -> table_name is better

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1208 (52f3655) into master (7f1ee34) will decrease coverage by 0%.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1208   +/-   ##
======================================
- Coverage      66%     66%   -1%     
======================================
  Files         416     415    -1     
  Lines       21801   21786   -15     
======================================
- Hits        14558   14545   -13     
+ Misses       7243    7241    -2     
Impacted Files Coverage Δ
...ry/query/src/datasources/remote/remote_database.rs 22% <0%> (ø)
fusestore/store/src/meta_service/state_machine.rs 0% <ø> (ø)
common/runtime/src/runtime.rs 83% <0%> (-14%) ⬇️
common/runtime/src/runtime_test.rs

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1ee34...52f3655. Read the comment docs.

@bohutang
bohutang requested a review from zhang2014 July 28, 2021 03:29

@dantengsky dantengsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks bro

@databend-bot

Copy link
Copy Markdown
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
databend-bot merged commit 1ae7c06 into databendlabs:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Metadata was not cleaned up when drop a remote database.

5 participants