Skip to content

[store] refactor: when testing, generate unique address for services#1224

Merged
databend-bot merged 1 commit into
databendlabs:masterfrom
drmingdrmer:unique-addr
Jul 29, 2021
Merged

[store] refactor: when testing, generate unique address for services#1224
databend-bot merged 1 commit into
databendlabs:masterfrom
drmingdrmer:unique-addr

Conversation

@drmingdrmer

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

[store] refactor: when testing, generate unique address for services

Changelog

  • Improvement

Related Issues

#271

@drmingdrmer drmingdrmer added this to the v0.5 milestone Jul 29, 2021
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

3 similar comments
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@drmingdrmer
drmingdrmer marked this pull request as ready for review July 29, 2021 06:24
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1224 (424d396) into master (b6d9835) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1224   +/-   ##
======================================
  Coverage      72%     72%           
======================================
  Files         464     464           
  Lines       27678   27678           
======================================
  Hits        20076   20076           
  Misses       7602    7602           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6d9835...424d396. Read the comment docs.

@dantengsky dantengsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dantengsky
dantengsky self-requested a review July 29, 2021 07:06
@databend-bot

Copy link
Copy Markdown
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
databend-bot merged commit f85b4c0 into databendlabs:master Jul 29, 2021
@drmingdrmer
drmingdrmer deleted the unique-addr branch July 29, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants