Skip to content

[store] refactor: remove MetaStore::{open,new}, open_create() is enough#1331

Merged
databend-bot merged 3 commits into
databendlabs:masterfrom
drmingdrmer:refact-store
Aug 7, 2021
Merged

[store] refactor: remove MetaStore::{open,new}, open_create() is enough#1331
databend-bot merged 3 commits into
databendlabs:masterfrom
drmingdrmer:refact-store

Conversation

@drmingdrmer

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

[store] refactor: remove MetaStore::{open,new}, open_create() is enough
[store] refactor: rename SledVarTypeTree::as_type to key_space
[store] refactor: remove dup impl: StateMachine::get_node() is provided by impl Placement

Changelog

  • Improvement

Related Issues

@drmingdrmer drmingdrmer added this to the v0.5 milestone Aug 7, 2021
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

3 similar comments
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@drmingdrmer
drmingdrmer marked this pull request as ready for review August 7, 2021 07:55
Comment thread fusestore/store/src/meta_service/raftmeta.rs
Comment thread fusestore/store/src/meta_service/sled_vartype_tree_test.rs
Comment thread fusestore/store/src/meta_service/state_machine.rs
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1331 (fffb9c1) into master (ae39181) will decrease coverage by 0%.
The diff coverage is 94%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1331   +/-   ##
======================================
- Coverage      72%     72%   -1%     
======================================
  Files         481     481           
  Lines       28021   28013    -8     
======================================
- Hits        20301   20292    -9     
- Misses       7720    7721    +1     
Impacted Files Coverage Δ
fusestore/store/src/meta_service/placement.rs 38% <0%> (ø)
...store/store/src/meta_service/state_machine_test.rs 89% <ø> (ø)
fusestore/store/src/meta_service/raftmeta.rs 77% <33%> (-1%) ⬇️
fusestore/store/src/meta_service/state_machine.rs 76% <77%> (+<1%) ⬆️
...usestore/store/src/meta_service/meta_store_test.rs 96% <100%> (+<1%) ⬆️
fusestore/store/src/meta_service/raft_log.rs 90% <100%> (ø)
...estore/store/src/meta_service/sled_vartype_tree.rs 92% <100%> (ø)
...e/store/src/meta_service/sled_vartype_tree_test.rs 97% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae39181...fffb9c1. Read the comment docs.

@ariesdevil
ariesdevil self-requested a review August 7, 2021 08:33
@databend-bot

Copy link
Copy Markdown
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
databend-bot merged commit 43671e0 into databendlabs:master Aug 7, 2021
@drmingdrmer
drmingdrmer deleted the refact-store branch August 7, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants