Skip to content

[store] refactor: RaftState: cleanup open-create: separate info extraction and staet initialization#1333

Merged
databend-bot merged 1 commit into
databendlabs:masterfrom
drmingdrmer:refact-state
Aug 7, 2021
Merged

[store] refactor: RaftState: cleanup open-create: separate info extraction and staet initialization#1333
databend-bot merged 1 commit into
databendlabs:masterfrom
drmingdrmer:refact-state

Conversation

@drmingdrmer

@drmingdrmer drmingdrmer commented Aug 7, 2021

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

[store] refactor: RaftState: cleanup open-create: separate info extraction and staet initialization
[store] refactor: add a field is_open to MetaStore and RaftState to indicate if it is opened from a previously saved state

Changelog

  • Improvement

Related Issues

@drmingdrmer drmingdrmer modified the milestone: v0.5 Aug 7, 2021
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

2 similar comments
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@drmingdrmer
drmingdrmer marked this pull request as ready for review August 7, 2021 10:44

@ariesdevil ariesdevil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, much clearer than before.

@codecov-commenter

codecov-commenter commented Aug 7, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1333 (dd8de6d) into master (d9daffb) will decrease coverage by 0%.
The diff coverage is 85%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1333   +/-   ##
======================================
- Coverage      72%     72%   -1%     
======================================
  Files         481     481           
  Lines       28029   28028    -1     
======================================
- Hits        20310   20308    -2     
- Misses       7719    7720    +1     
Impacted Files Coverage Δ
fusestore/store/src/meta_service/raft_state.rs 86% <85%> (-1%) ⬇️
fusestore/store/src/meta_service/raftmeta.rs 78% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9daffb...dd8de6d. Read the comment docs.

@databend-bot

Copy link
Copy Markdown
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
databend-bot merged commit 7b31dd2 into databendlabs:master Aug 7, 2021
@drmingdrmer
drmingdrmer deleted the refact-state branch August 7, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants