Skip to content

[store] refactor: nothing really changed#1355

Merged
databend-bot merged 3 commits into
databendlabs:masterfrom
drmingdrmer:rename-serde
Aug 9, 2021
Merged

[store] refactor: nothing really changed#1355
databend-bot merged 3 commits into
databendlabs:masterfrom
drmingdrmer:rename-serde

Conversation

@drmingdrmer

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

[store] refactor: remove unused method in trait SledOrderedSerde
[store] refactor: remove unused MetaNodeBuilder::start_grpc_service
[store] refactor: nothing changed, just rename
SledVarTypeTree -> SledTree
AsType -> AsKeySpace
SledKV -> SledKeySpace

Changelog

  • Improvement

Related Issues

@drmingdrmer drmingdrmer added this to the v0.5 milestone Aug 8, 2021
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

1 similar comment
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@drmingdrmer drmingdrmer changed the title [store] refactor: remove unused method in trait SledOrderedSerde [store] refactor: nothing really changed Aug 8, 2021
@drmingdrmer
drmingdrmer marked this pull request as ready for review August 8, 2021 18:29
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1355 (72595ab) into master (ecdb540) will increase coverage by 0%.
The diff coverage is 98%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1355   +/-   ##
======================================
  Coverage      72%     72%           
======================================
  Files         486     486           
  Lines       28087   28073   -14     
======================================
+ Hits        20271   20276    +5     
+ Misses       7816    7797   -19     
Impacted Files Coverage Δ
fusestore/store/src/meta_service/raft_state_kv.rs 64% <ø> (+7%) ⬆️
fusestore/store/src/meta_service/sled_key_space.rs 94% <ø> (ø)
fusestore/store/src/meta_service/sled_serde.rs 91% <ø> (-3%) ⬇️
...store/store/src/meta_service/state_machine_meta.rs 60% <ø> (+6%) ⬆️
...store/store/src/meta_service/state_machine_test.rs 89% <ø> (ø)
fusestore/store/src/meta_service/raft_state.rs 90% <66%> (ø)
fusestore/store/src/meta_service/state_machine.rs 76% <80%> (ø)
fusestore/store/src/meta_service/raft_log.rs 90% <100%> (ø)
fusestore/store/src/meta_service/raft_types.rs 76% <100%> (+30%) ⬆️
fusestore/store/src/meta_service/raftmeta.rs 79% <100%> (+<1%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecdb540...72595ab. Read the comment docs.

@bohutang bohutang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@databend-bot

Copy link
Copy Markdown
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
databend-bot merged commit 23b7d78 into databendlabs:master Aug 9, 2021
@drmingdrmer
drmingdrmer deleted the rename-serde branch August 9, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants