Skip to content

[store] refactor: use UpsertKV to impl delete operation.#1378

Merged
databend-bot merged 1 commit into
databendlabs:masterfrom
drmingdrmer:rewrite-drop-user
Aug 9, 2021
Merged

[store] refactor: use UpsertKV to impl delete operation.#1378
databend-bot merged 1 commit into
databendlabs:masterfrom
drmingdrmer:rewrite-drop-user

Conversation

@drmingdrmer

@drmingdrmer drmingdrmer commented Aug 9, 2021

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

[store] refactor: use UpsertKV to impl delete operation.

61 LOC reduced:DDD

Changelog

  • Improvement

Related Issues

@drmingdrmer drmingdrmer added this to the v0.5 milestone Aug 9, 2021
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

1 similar comment
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@drmingdrmer
drmingdrmer marked this pull request as ready for review August 9, 2021 14:18
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1378 (e304a16) into master (77f2cb3) will increase coverage by 0%.
The diff coverage is 98%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1378   +/-   ##
======================================
  Coverage      72%     72%           
======================================
  Files         493     493           
  Lines       28398   28376   -22     
======================================
- Hits        20543   20528   -15     
+ Misses       7855    7848    -7     
Impacted Files Coverage Δ
common/flights/src/store_do_action.rs 90% <ø> (-1%) ⬇️
common/store-api/src/kv_api.rs 75% <ø> (ø)
fusestore/store/src/executor/action_handler.rs 59% <ø> (-1%) ⬇️
common/flights/src/impls/kv_api_impl.rs 82% <50%> (+<1%) ⬆️
common/management/src/user/user_mgr.rs 96% <100%> (ø)
common/management/src/user/user_mgr_test.rs 99% <100%> (+<1%) ⬆️
fusestore/store/src/api/rpc/flight_service_test.rs 95% <100%> (+<1%) ⬆️
fusestore/store/src/executor/kv_handlers.rs 92% <100%> (+4%) ⬆️
fusestore/store/src/meta_service/raftmeta.rs 79% <0%> (+<1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f2cb3...e304a16. Read the comment docs.

@ariesdevil ariesdevil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@databend-bot

Copy link
Copy Markdown
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
databend-bot merged commit b2f9aae into databendlabs:master Aug 9, 2021
@drmingdrmer
drmingdrmer deleted the rewrite-drop-user branch August 9, 2021 16:18
ariesdevil pushed a commit to ariesdevil/databend that referenced this pull request Aug 9, 2021
[store] refactor: use UpsertKV to impl delete operation.
ariesdevil pushed a commit to ariesdevil/databend that referenced this pull request Aug 9, 2021
[store] refactor: use UpsertKV to impl delete operation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants