Skip to content

[store] feature: add SledTree::remove() to delete a single elt.#1399

Merged
drmingdrmer merged 1 commit into
databendlabs:masterfrom
drmingdrmer:sledtree-del
Aug 10, 2021
Merged

[store] feature: add SledTree::remove() to delete a single elt.#1399
drmingdrmer merged 1 commit into
databendlabs:masterfrom
drmingdrmer:sledtree-del

Conversation

@drmingdrmer

@drmingdrmer drmingdrmer commented Aug 10, 2021

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

[store] feature: add SledTree::remove() to delete a single elt.

Changelog

  • New Feature

Related Issues

@drmingdrmer drmingdrmer added this to the v0.5 milestone Aug 10, 2021
@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Aug 10, 2021
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

1 similar comment
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@drmingdrmer
drmingdrmer marked this pull request as ready for review August 10, 2021 05:53
@codecov-commenter

codecov-commenter commented Aug 10, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1399 (fa92378) into master (112f3a6) will increase coverage by 0%.
The diff coverage is 97%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1399   +/-   ##
======================================
  Coverage      72%     72%           
======================================
  Files         493     493           
  Lines       28394   28471   +77     
======================================
+ Hits        20537   20611   +74     
- Misses       7857    7860    +3     
Impacted Files Coverage Δ
fusestore/store/src/meta_service/sled_tree.rs 92% <93%> (+<1%) ⬆️
fusestore/store/src/meta_service/sled_tree_test.rs 97% <100%> (+<1%) ⬆️
fusestore/store/src/meta_service/network.rs 46% <0%> (-2%) ⬇️
...estore/store/src/meta_service/meta_service_impl.rs 56% <0%> (-2%) ⬇️
fusestore/store/src/meta_service/raftmeta.rs 79% <0%> (-1%) ⬇️
common/datablocks/src/kernels/data_block_sort.rs 91% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112f3a6...fa92378. Read the comment docs.

@drmingdrmer
drmingdrmer marked this pull request as draft August 10, 2021 07:43
@drmingdrmer
drmingdrmer marked this pull request as ready for review August 10, 2021 08:20
@drmingdrmer
drmingdrmer merged commit 1acb316 into databendlabs:master Aug 10, 2021
@drmingdrmer
drmingdrmer deleted the sledtree-del branch August 10, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants