Support SHOW TABLES LIKE pattern and Where expr by mapleFU · Pull Request #1518 · databendlabs/databend

mapleFU · 2021-08-18T18:10:37Z

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

Summary about this PR

This pr supports like 'pattern' and where expr in show tables. I use some interface of sqlparse, and I don't know does I really catch it.

Changelog

New Feature

Related Issues

Fixes #1388 #1389

Test Plan

Unit Tests

databend-bot · 2021-08-18T18:10:40Z

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

databend-bot · 2021-08-18T18:10:41Z

Hello @mapleFU, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

sundy-li · 2021-08-19T01:24:29Z

@mapleFU LGTM, better to add a stateless test in 06_0000_show_queries.sql

codecov-commenter · 2021-08-19T01:36:32Z

Codecov Report

Merging #1518 (51c7e89) into master (fd1c308) will increase coverage by 0%.
The diff coverage is 65%.

@@           Coverage Diff           @@
##           master   #1518    +/-   ##
=======================================
  Coverage      72%     73%            
=======================================
  Files         521     528     +7     
  Lines       31533   32229   +696     
=======================================
+ Hits        22997   23746   +749     
+ Misses       8536    8483    -53

Impacted Files	Coverage Δ
query/src/sql/plan_parser.rs	`76% <0%> (-1%)`	⬇️
query/src/sql/sql_parser.rs	`76% <66%> (-1%)`	⬇️
query/src/sql/sql_parser_test.rs	`93% <100%> (+<1%)`	⬆️
query/src/sql/sql_statement.rs	`72% <100%> (+<1%)`	⬆️
common/datavalues/src/types/data_type_coercion.rs	`70% <0%> (-10%)`	⬇️
...pelines/transforms/transform_aggregator_partial.rs	`89% <0%> (-2%)`	⬇️
query/src/sql/parser/ast/query.rs	`46% <0%> (-1%)`	⬇️
store/src/meta_service/raftmeta_test.rs	`94% <0%> (-1%)`	⬇️
common/datavalues/src/series/wrap.rs	`61% <0%> (-1%)`	⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1c308...51c7e89. Read the comment docs.

zhang2014 · 2021-08-19T02:28:43Z

-                            Ok(DfStatement::ShowTables(DfShowTables))
+                            let tok = self.parser.next_token();
+                            match &tok {
+                                Token::EOF => Ok(DfStatement::ShowTables(DfShowTables::All)),


What happens to the following SQL?

SHOW TABLES ; SHOW TABLES -- comment

I will add some tests and check if it's ok tonight.

zhang2014 · 2021-08-19T02:33:06Z

+                            self.ctx.get_current_database(), i,
+                        )
+                    }
+                    DfShowTables::Where(e) => {


What happens to the following SQL?

SHOW TABLES WHERE 1 = 1 OR 1 = 1

What happens to the following SQL?

SHOW TABLES WHERE 1 = 1 OR 1 = 1

It's ok, we don't care about it, just let it be any complex expr. The optimize / select executor will handle that.

According to MySQL standard,parse_expr can handle all of them: https://dev.mysql.com/doc/refman/5.7/en/expressions.html

Buf I didn't check the code in sqlparse-rs, so I cannot guarantee it works well.

May this change the behavior of the query?

After format:
SELECT name FROM system.tables where database = '{}' AND 1 = 1 OR 1 = 1 ORDER BY database, name

May this change the behavior of the query?

After format:
SELECT name FROM system.tables where database = '{}' AND 1 = 1 OR 1 = 1 ORDER BY database, name

Got It. Sorry for misunderstanding this case! I will adding tests about it in stateless test.

evaluation proceeds left to right, with the exception that assignments evaluate right to left

According to https://dev.mysql.com/doc/refman/8.0/en/operator-precedence.html , it will not return all tables. But I think maybe it's proper to build sql like:

SELECT name FROM system.tables where database = '{}' AND (1 = 1 OR 1 = 1) ORDER BY database, name

@zhang2014 do you think it's ok?

@zhang2014 do you think it's ok?

It looks ok

mapleFU · 2021-08-19T15:18:51Z

@zhang2014 @sundy-li Sorry for fixing the problem so late!

I add some tests in stateless, and wrap where expr with ().

There are some cases:

commit d9eaee0 remove the handling about ;, because it was already processed.
When I build sql like from system.tables where ... name = t or 1 = 1 without (), some system table was printed. I have tried it on MySQL but mysql will not print these messages.

sundy-li

LGTM, thanks @mapleFU

databend-bot · 2021-08-20T01:41:44Z

CI Passed
Reviewer Approved
Let's Merge

mapleFU added 3 commits August 19, 2021 00:53

Init: Extent DfShowTables and parsing it

b77be14

ximplement basic logics and tests

a5ef5a0

fix a place for token

77c27ac

databend-bot added the pr-feature this PR introduces a new feature to the codebase label Aug 18, 2021

bohutang requested review from leiysky and sundy-li and removed request for sundy-li August 19, 2021 01:08

zhang2014 reviewed Aug 19, 2021

View reviewed changes

mapleFU added 2 commits August 19, 2021 11:49

adding more test about complex expr

e37835d

test: adding extra checking for comma

7baecf6

sundy-li mentioned this pull request Aug 19, 2021

Support SHOW DATABASE LIKE statement and Where Expr #1390

Closed

mapleFU added 3 commits August 19, 2021 23:00

bugfix and add testing

1e30fbf

finish stateless tests

8da0e67

remove: remove handling column

d9eaee0

sundy-li added 3 commits August 20, 2021 08:05

Add newline

60fa56a

Update plan_parser.rs

756ae2d

Update plan_parser.rs

51c7e89

sundy-li approved these changes Aug 20, 2021

View reviewed changes

databend-bot merged commit 5eb2ba8 into databendlabs:master Aug 20, 2021

Uh oh!

Conversation

mapleFU commented Aug 18, 2021 • edited by zhang2014 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changelog

Related Issues

Test Plan

Uh oh!

databend-bot commented Aug 18, 2021

Uh oh!

databend-bot commented Aug 18, 2021

Uh oh!

sundy-li commented Aug 19, 2021

Uh oh!

codecov-commenter commented Aug 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mapleFU Aug 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mapleFU commented Aug 19, 2021

Uh oh!

sundy-li left a comment

Choose a reason for hiding this comment

Uh oh!

databend-bot commented Aug 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mapleFU commented Aug 18, 2021 •

edited by zhang2014

Loading

codecov-commenter commented Aug 19, 2021 •

edited

Loading

mapleFU Aug 19, 2021 •

edited

Loading