[clickhouse-handler] print error stacktrace in clickhouse-handler#1525
Conversation
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
|
Hello @xuyifangreeneyes, 🎉 Thank you for opening the pull request! 🎉 |
|
After the PR: clickhouse-client output: datafuse-query output: We can see error stacktrace in log when the user enters an invalid query. It seems that |
|
Besides, I cannot find a way to let |
Codecov Report
@@ Coverage Diff @@
## master #1525 +/- ##
======================================
- Coverage 72% 72% -1%
======================================
Files 527 527
Lines 31755 31768 +13
======================================
- Hits 23176 23142 -34
- Misses 8579 8626 +47
Continue to review full report at Codecov.
|
|
CI Passed |
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
Summary about this PR
datafuse_query::servers::clickhouse::writers::query_writer::QueryWriter::write_errorso we can see error stacktrace in datafuse-query's log.datafuse_query::servers::clickhouse::writers::query_writer::QueryWriter::writereturns an error. Similar to Edit log query string when mysql_session error #1353.Changelog
Related Issues
Fixes #1329
Test Plan
Manual test