Skip to content

[datavalues] complete null array cast#1543

Merged
databend-bot merged 1 commit into
databendlabs:masterfrom
zhyass:feature_if
Aug 20, 2021
Merged

[datavalues] complete null array cast#1543
databend-bot merged 1 commit into
databendlabs:masterfrom
zhyass:feature_if

Conversation

@zhyass

@zhyass zhyass commented Aug 20, 2021

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

Summary about this PR

Changelog

  • Improvement

Related Issues

Fixes #1542

Test Plan

Stateless Tests

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot

Copy link
Copy Markdown
Member

Hello @zhyass, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

@codecov-commenter

codecov-commenter commented Aug 20, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1543 (da51cad) into master (0b051f5) will decrease coverage by 0%.
The diff coverage is 23%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1543   +/-   ##
======================================
- Coverage      73%     73%   -1%     
======================================
  Files         528     528           
  Lines       32266   32286   +20     
======================================
+ Hits        23786   23792    +6     
- Misses       8480    8494   +14     
Impacted Files Coverage Δ
common/datavalues/src/types/data_type_coercion.rs 68% <0%> (-2%) ⬇️
common/datavalues/src/arrays/ops/cast.rs 57% <29%> (-18%) ⬇️
query/src/common/hash_table.rs 63% <0%> (-1%) ⬇️
store/src/meta_service/raftmeta_test.rs 94% <0%> (+<1%) ⬆️
store/src/meta_service/meta_service_impl.rs 76% <0%> (+1%) ⬆️
store/src/meta_service/network.rs 80% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b051f5...da51cad. Read the comment docs.

@databend-bot

Copy link
Copy Markdown
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
databend-bot merged commit 5cde9ae into databendlabs:master Aug 20, 2021
@zhyass
zhyass deleted the feature_if branch August 21, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

complete null array cast

4 participants