Skip to content

[1635]Rename datasource to catalog#1636

Merged
databend-bot merged 2 commits into
databendlabs:masterfrom
GrapeBaBa:issue_1635
Aug 28, 2021
Merged

[1635]Rename datasource to catalog#1636
databend-bot merged 2 commits into
databendlabs:masterfrom
GrapeBaBa:issue_1635

Conversation

@GrapeBaBa

Copy link
Copy Markdown
Contributor

Signed-off-by: grapebaba 281165273@qq.com

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

Rename datasource to catalog

Changelog

  • Improvement

Related Issues

Fixes #1635

Test Plan

Unit Tests

Stateless Tests

Signed-off-by: grapebaba <281165273@qq.com>
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot

Copy link
Copy Markdown
Member

Hello @GrapeBaBa, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

Signed-off-by: grapebaba <281165273@qq.com>

@bohutang bohutang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @GrapeBaBa

@codecov-commenter

codecov-commenter commented Aug 28, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1636 (4863cb2) into master (38f83d8) will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1636   +/-   ##
======================================
  Coverage      73%     73%           
======================================
  Files         543     543           
  Lines       33132   33132           
======================================
  Hits        24437   24437           
  Misses       8695    8695           
Impacted Files Coverage Δ
query/src/datasources/system/databases_table.rs 81% <100%> (ø)
query/src/datasources/system/tables_table.rs 82% <100%> (ø)
...ry/src/interpreters/interpreter_database_create.rs 78% <100%> (ø)
...uery/src/interpreters/interpreter_database_drop.rs 93% <100%> (ø)
query/src/interpreters/interpreter_insert_into.rs 84% <100%> (ø)
.../src/interpreters/interpreter_show_create_table.rs 97% <100%> (ø)
query/src/interpreters/interpreter_table_create.rs 93% <100%> (ø)
query/src/interpreters/interpreter_table_drop.rs 93% <100%> (ø)
query/src/sql/plan_parser.rs 75% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38f83d8...4863cb2. Read the comment docs.

@databend-bot

Copy link
Copy Markdown
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
databend-bot merged commit 3ed9f02 into databendlabs:master Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[improvement] Consider rename datasource to catalog

4 participants