Skip to content

Fix mysqlhandler log bug#1646

Merged
databend-bot merged 1 commit into
databendlabs:masterfrom
GrapeBaBa:bug_log
Aug 29, 2021
Merged

Fix mysqlhandler log bug#1646
databend-bot merged 1 commit into
databendlabs:masterfrom
GrapeBaBa:bug_log

Conversation

@GrapeBaBa

Copy link
Copy Markdown
Contributor

Signed-off-by: grapebaba 281165273@qq.com

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

Summary about this PR

Changelog

  • Bug Fix

Related Issues

no

Test Plan

Unit Tests

Stateless Tests

Signed-off-by: grapebaba <281165273@qq.com>
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot databend-bot added the pr-bugfix this PR patches a bug in codebase label Aug 29, 2021
@databend-bot

Copy link
Copy Markdown
Member

Hello @GrapeBaBa, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

@codecov-commenter

codecov-commenter commented Aug 29, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1646 (5f5b54d) into master (108a018) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1646   +/-   ##
======================================
  Coverage      73%     73%           
======================================
  Files         545     545           
  Lines       33140   33140           
======================================
+ Hits        24433   24439    +6     
+ Misses       8707    8701    -6     
Impacted Files Coverage Δ
store/src/meta_service/state_machine.rs 90% <0%> (-1%) ⬇️
store/src/meta_service/raftmeta.rs 93% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 108a018...5f5b54d. Read the comment docs.

@bohutang bohutang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @GrapeBaBa

@databend-bot

Copy link
Copy Markdown
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
databend-bot merged commit b279896 into databendlabs:master Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants