Skip to content

ISSUE-1700: user namespace API#1727

Merged
databend-bot merged 10 commits into
databendlabs:masterfrom
bohutang:dev-user-api-1700
Sep 5, 2021
Merged

ISSUE-1700: user namespace API#1727
databend-bot merged 10 commits into
databendlabs:masterfrom
bohutang:dev-user-api-1700

Conversation

@bohutang

@bohutang bohutang commented Sep 5, 2021

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

  1. Refine the Config ENV variable name to prefix with the Group name, LOG_/QUERY_/META_/STORE_
  2. Add tenant and namespace to QueryConfig group
  3. Add common/management/namespace mod

Changelog

  • Improvement

Related Issues

Part-1 of #1700
Fixes #1724

Test Plan

Unit Tests

Stateless Tests

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter

codecov-commenter commented Sep 5, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1727 (46b8f86) into master (0d10503) will increase coverage by 0%.
The diff coverage is 92%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1727    +/-   ##
=======================================
  Coverage      72%     72%            
=======================================
  Files         573     576     +3     
  Lines       33938   34329   +391     
=======================================
+ Hits        24642   25012   +370     
- Misses       9296    9317    +21     
Impacted Files Coverage Δ
query/src/configs/config.rs 62% <41%> (+<1%) ⬆️
common/management/src/namespace/namespace_api.rs 46% <46%> (ø)
...mon/management/src/namespace/namespace_mgr_test.rs 96% <96%> (ø)
common/management/src/namespace/namespace_mgr.rs 97% <97%> (ø)
query/src/configs/config_test.rs 66% <100%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d10503...46b8f86. Read the comment docs.

@bohutang bohutang changed the title ISSUE-1700: user API ISSUE-1700: user namespace API Sep 5, 2021
@bohutang
bohutang marked this pull request as ready for review September 5, 2021 12:30
@bohutang

bohutang commented Sep 5, 2021

Copy link
Copy Markdown
Member Author

/review @zhang2014

@databend-bot

Copy link
Copy Markdown
Member

Take the reviewer to zhang2014

@zhang2014 zhang2014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@databend-bot

Copy link
Copy Markdown
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
databend-bot merged commit f09ef83 into databendlabs:master Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] add tenant config to QueryConfig group

4 participants