Skip to content

DS-1812: move datasources utils to datasources/common#1813

Merged
databend-bot merged 1 commit into
databendlabs:masterfrom
bohutang:dev-datasource-1812
Sep 13, 2021
Merged

DS-1812: move datasources utils to datasources/common#1813
databend-bot merged 1 commit into
databendlabs:masterfrom
bohutang:dev-datasource-1812

Conversation

@bohutang

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

move datasources utils to datasources/common, this PR:

  1. split the common to part.rs and line.rs

Changelog

  • Improvement

Related Issues

Fixes #1812

Test Plan

Unit Tests

Stateless Tests

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@bohutang
bohutang requested a review from dantengsky September 13, 2021 09:46
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1813 (d543aad) into master (5282e51) will not change coverage.
The diff coverage is 93%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1813   +/-   ##
======================================
  Coverage      70%     70%           
======================================
  Files         629     631    +2     
  Lines       37486   37486           
======================================
  Hits        26423   26423           
  Misses      11063   11063           
Impacted Files Coverage Δ
query/src/datasources/common/line_test.rs 87% <87%> (ø)
query/src/datasources/common/line.rs 92% <92%> (ø)
query/src/datasources/common/part.rs 94% <94%> (ø)
query/src/datasources/common/part_test.rs 100% <100%> (ø)
query/src/datasources/local/csv_table.rs 75% <100%> (ø)
query/src/datasources/local/memory_table.rs 87% <100%> (ø)
query/src/datasources/system/numbers_table.rs 79% <100%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5282e51...d543aad. Read the comment docs.

@dantengsky dantengsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@databend-bot

Copy link
Copy Markdown
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
databend-bot merged commit 8f0cf97 into databendlabs:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[improvement] move datasources utils to datasources/common

4 participants