fix(query): stop flight exchange task after shutdown - #20229
Merged
Conversation
Member
Author
|
The CI failure is unrelated to this PR. The same test case also fails on the |
zhang2014
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
root cause: WatchNotify is sticky; calling notified() again would spin forever.
flowchart TD A["ExchangeSinkBuffer / PingPongExchange drop"] --> B["shutdown.notify_waiters()"] B --> C["PingPong task: finished = true"] C --> D["callback.has_pending()"] D --> E["recreate shutdown.notified()"] E --> F["sticky notification Ready immediately"] F --> Cfix: after finished signal, only drain the steam not wait
notifiedfuture again.close: #20228
Tests
Type of change
AI assistance
This change is