fix(query): make hash join streams interruptible - #20236
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e7f6dc515
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
New hash join streams could remain inside a single
Processor::process()call while consuming an unbounded number of internal batches. If the query was killed during that work, the processor did not return to the scheduler to observe cancellation.This PR:
system.processesThere are no migrations, configuration changes, or rollout steps.
Tests
Validation:
cargo check -p databend-query --libcargo clippy -p databend-query --lib -- -D warningscargo fmt --all -- --checkpython3 -m py_compile tests/suites/1_stateful/02_query/02_0000_kill_query.pyType of change
This change is
AI assistance