Skip to content

[RFC] ISSUE-3379 New processor framework#3380

Merged
bohutang merged 31 commits into
databendlabs:mainfrom
zhang2014:new_processors_framwork
Jan 20, 2022
Merged

[RFC] ISSUE-3379 New processor framework#3380
bohutang merged 31 commits into
databendlabs:mainfrom
zhang2014:new_processors_framwork

Conversation

@zhang2014

@zhang2014 zhang2014 commented Dec 11, 2021

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Implement Push-base and Pull-base processor framework

Changelog

  • Improvement

Related Issues

fixes #3926

Test Plan

Unit Tests

Stateless Tests

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel

vercel Bot commented Dec 11, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/52ZPenT1bxa7ux7vWLGb5q7Y3qvR
✅ Preview: https://databend-git-fork-zhang2014-newprocessorsframwork-databend.vercel.app

[Deployment for 56c2907 canceled]

@zhang2014 zhang2014 changed the title [RFC] ISSUE-3379 merge trait Processor and trait SendableStream [RFC] ISSUE-3379 try merge trait Processor and trait SendableStream Dec 11, 2021
@zhang2014 zhang2014 changed the title [RFC] ISSUE-3379 try merge trait Processor and trait SendableStream [RFC] ISSUE-3379 try merge Processor and SendableStream Dec 11, 2021
@zhang2014 zhang2014 changed the title [RFC] ISSUE-3379 try merge Processor and SendableStream [RFC] ISSUE-3379 try merge Processor and SendableDataBlockStream Dec 11, 2021
Comment thread query/src/pipelines/new/executor/executor_tasks.rs Outdated
@mergify

mergify Bot commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be merged. @zhang2014 please rebase it 🙏

@zhang2014 zhang2014 changed the title [RFC] ISSUE-3379 try merge Processor and SendableDataBlockStream [RFC] ISSUE-3379 New processor framework Dec 24, 2021
# Conflicts:
#	common/exception/src/exception.rs
Comment thread query/src/pipelines/new/executor/executor_tasks.rs Outdated
# Conflicts:
#	common/exception/src/exception.rs
#	query/Cargo.toml
@zhang2014
zhang2014 marked this pull request as ready for review January 20, 2022 04:38
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #3380 (56c2907) into main (c54f06f) will decrease coverage by 0%.
The diff coverage is 37%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3380     +/-   ##
=======================================
- Coverage     57%     56%     -1%     
=======================================
  Files        773     800     +27     
  Lines      41265   42749   +1484     
=======================================
+ Hits       23839   24364    +525     
- Misses     17426   18385    +959     
Impacted Files Coverage Δ
common/infallible/src/condvar.rs 32% <0%> (ø)
common/infallible/src/mutex.rs 81% <ø> (-19%) ⬇️
...uery/src/pipelines/new/executor/executor_notify.rs 0% <0%> (ø)
query/src/pipelines/new/executor/executor_tasks.rs 0% <0%> (ø)
.../pipelines/new/executor/executor_worker_context.rs 0% <0%> (ø)
...ry/src/pipelines/new/executor/pipeline_executor.rs 0% <0%> (ø)
...ipelines/new/executor/pipeline_runtime_executor.rs 0% <0%> (ø)
...ipelines/new/executor/pipeline_threads_executor.rs 0% <0%> (ø)
query/src/pipelines/new/pipeline_builder.rs 0% <0%> (ø)
...c/pipelines/new/processors/sources/async_source.rs 0% <0%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c54f06f...56c2907. Read the comment docs.

@bohutang

Copy link
Copy Markdown
Member

/lgtm

Let's merge!

@databend-bot

Copy link
Copy Markdown
Member

Wait for another reviewer approval

@bohutang
bohutang merged commit b837015 into databendlabs:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add new processor trait and implement new processor framework

4 participants