Skip to content

ISSUE-3603 add DataTypeAndNullable#3658

Merged
sundy-li merged 7 commits into
databendlabs:mainfrom
zhang2014:refactor/nullable
Dec 29, 2021
Merged

ISSUE-3603 add DataTypeAndNullable#3658
sundy-li merged 7 commits into
databendlabs:mainfrom
zhang2014:refactor/nullable

Conversation

@zhang2014

@zhang2014 zhang2014 commented Dec 27, 2021

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

Add DataTypeAndNullable struct to desc type and nullable

Changelog

  • Improvement

Related Issues

#3603

Test Plan

Unit Tests

Stateless Tests

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel

vercel Bot commented Dec 27, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/HRZBUhPiDmSxdL2zoMe3t4jizPAN
✅ Preview: Canceled

[Deployment for 05b8051 canceled]

@bohutang

Copy link
Copy Markdown
Member

Is this PR related to #3664?

@sundy-li

Copy link
Copy Markdown
Member

Is this PR related to #3664?

It's part of that, this pr can be addressed.

@junli1026

Copy link
Copy Markdown
Contributor

Is this PR related to #3664?

It's part of that, this pr can be addressed.

If I understand correctly, the final goal is to replace the DataTypeAndNullable with Nullable(Box<DataType>), right ?

@zhang2014
zhang2014 marked this pull request as ready for review December 28, 2021 14:25
@codecov-commenter

codecov-commenter commented Dec 28, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3658 (05b8051) into main (4f30a6b) will decrease coverage by 0%.
The diff coverage is 64%.

Impacted file tree graph

@@          Coverage Diff           @@
##            main   #3658    +/-   ##
======================================
- Coverage     60%     60%    -1%     
======================================
  Files        678     697    +19     
  Lines      36484   37227   +743     
======================================
+ Hits       21951   22368   +417     
- Misses     14533   14859   +326     
Impacted Files Coverage Δ
common/datavalues/src/data_schema.rs 84% <ø> (ø)
...n/functions/src/scalars/dates/interval_function.rs 75% <0%> (ø)
common/functions/src/scalars/dates/now.rs 16% <0%> (ø)
common/functions/src/scalars/dates/simple_date.rs 10% <0%> (ø)
common/functions/src/scalars/dates/week_date.rs 15% <0%> (ø)
common/functions/src/scalars/function_alias.rs 0% <0%> (ø)
common/functions/src/scalars/function_column.rs 42% <0%> (ø)
common/functions/src/scalars/function_literal.rs 0% <0%> (ø)
common/functions/src/scalars/maths/random.rs 8% <0%> (-30%) ⬇️
common/functions/src/scalars/others/ignore.rs 19% <0%> (ø)
... and 180 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be8994...05b8051. Read the comment docs.

@databend-bot

Copy link
Copy Markdown
Member

Wait for another reviewer approval

@sundy-li
sundy-li merged commit 79bf5e1 into databendlabs:main Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants