Skip to content

ISSUE-3560: Add generate command for bendctl#3732

Merged
bohutang merged 3 commits into
databendlabs:mainfrom
kevinw66:generate
Jan 3, 2022
Merged

ISSUE-3560: Add generate command for bendctl#3732
bohutang merged 3 commits into
databendlabs:mainfrom
kevinw66:generate

Conversation

@kevinw66

@kevinw66 kevinw66 commented Jan 2, 2022

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Add generate command for bendctl

Changelog

  • Improvement

Related Issues

Fixes #3560

Test Plan

Unit Tests

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel

vercel Bot commented Jan 2, 2022

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/6yHMUmneafcQr6cUD8sKhFkqtJVi
✅ Preview: Canceled

[Deployment for 1ae6f44 canceled]

@codecov-commenter

codecov-commenter commented Jan 2, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3732 (1ae6f44) into main (9a9351d) will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##            main   #3732    +/-   ##
======================================
- Coverage     60%     59%    -1%     
======================================
  Files        706     707     +1     
  Lines      37971   38206   +235     
======================================
- Hits       22805   22786    -19     
- Misses     15166   15420   +254     
Impacted Files Coverage Δ
tools/benchmark/src/main.rs <1% <ø> (ø)
common/clickhouse-srv/src/binary/mod.rs 0% <0%> (-92%) ⬇️
query/src/users/user_udf.rs 75% <0%> (-19%) ⬇️
query/src/common/mod.rs 70% <0%> (-15%) ⬇️
metasrv/src/store/meta_raft_store.rs 76% <0%> (-3%) ⬇️
common/datavalues/src/data_value_ops.rs 59% <0%> (-2%) ⬇️
...pelines/transforms/transform_aggregator_partial.rs 86% <0%> (-2%) ⬇️
common/dal/src/context.rs 68% <0%> (-2%) ⬇️
common/meta/types/src/table.rs 98% <0%> (ø)
query/src/sql/planner/binder.rs 0% <0%> (ø)
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11fa94b...1ae6f44. Read the comment docs.

@bohutang

bohutang commented Jan 3, 2022

Copy link
Copy Markdown
Member

Good.
It would be nice to add a doc for how to use the generate command.

@kevinw66

kevinw66 commented Jan 3, 2022

Copy link
Copy Markdown
Contributor Author

Good. It would be nice to add a doc for how to use the generate command.

There is no right place to add document for the command. So I add it in old ontime README.md file

@bohutang

bohutang commented Jan 3, 2022

Copy link
Copy Markdown
Member

/lgtm
Thank you @kevinw66 !

@bohutang
bohutang merged commit fd99ff5 into databendlabs:main Jan 3, 2022
@kevinw66
kevinw66 deleted the generate branch January 3, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bendctl: Support bendctl generate --dataset ontime

4 participants