Skip to content

Mergeing pr 3666:Rename to common-ast package#3734

Merged
bohutang merged 2 commits into
databendlabs:mainfrom
sundy-li:merging-3666
Jan 3, 2022
Merged

Mergeing pr 3666:Rename to common-ast package#3734
bohutang merged 2 commits into
databendlabs:mainfrom
sundy-li:merging-3666

Conversation

@sundy-li

@sundy-li sundy-li commented Jan 3, 2022

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Changelog

  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #3660

Test Plan

Unit Tests

Stateless Tests

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

1 similar comment
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel

vercel Bot commented Jan 3, 2022

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/2ES3aukFo3nScbzVVUnnkA85XYJP
✅ Preview: Canceled

[Deployment for e3c44ec canceled]

@sundy-li sundy-li changed the title Mergeing issue 3666 Mergeing pr 3666 Jan 3, 2022
@sundy-li
sundy-li requested review from PsiACE and leiysky January 3, 2022 03:37
@sundy-li sundy-li changed the title Mergeing pr 3666 Mergeing pr 3666:Rename to common-ast package Jan 3, 2022

@PsiACE PsiACE left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

codecov-commenter commented Jan 3, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3734 (e3c44ec) into main (434c58e) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3734   +/-   ##
=====================================
  Coverage     59%     59%           
=====================================
  Files        707     707           
  Lines      38206   38206           
=====================================
+ Hits       22813   22817    +4     
+ Misses     15393   15389    -4     
Impacted Files Coverage Δ
common/ast/src/expr/expr_visitor.rs 63% <ø> (ø)
common/ast/src/parser/ast/expression.rs 43% <ø> (ø)
common/ast/src/parser/ast/mod.rs 23% <ø> (ø)
common/ast/src/parser/ast/query.rs 48% <ø> (ø)
common/ast/src/parser/ast/statement.rs 47% <ø> (ø)
common/ast/src/parser/mod.rs 81% <ø> (ø)
common/ast/src/parser/transformer/mod.rs 100% <ø> (ø)
.../ast/src/parser/transformer/transform_sqlparser.rs 48% <ø> (ø)
common/functions/src/udfs/udf_parser.rs 91% <ø> (ø)
query/src/sql/planner/bind_context.rs 0% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6603392...e3c44ec. Read the comment docs.

@databend-bot

Copy link
Copy Markdown
Member

Wait for another reviewer approval

@bohutang
bohutang merged commit bb026a0 into databendlabs:main Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It seems this crate only involves expr_visitor, what about rename it to common-ast? Since the name common-sql looks too common.

5 participants