Skip to content

Refine mysql hints on server startup#3921

Merged
bohutang merged 1 commit into
databendlabs:mainfrom
TennyZhuang:patch-1
Jan 20, 2022
Merged

Refine mysql hints on server startup#3921
bohutang merged 1 commit into
databendlabs:mainfrom
TennyZhuang:patch-1

Conversation

@TennyZhuang

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Changelog

  • Improvement
  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #issue

Test Plan

Unit Tests

Stateless Tests

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel

vercel Bot commented Jan 20, 2022

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/9pRqXpPsobG51iJTn5aUeFdHwUHV
✅ Preview: Canceled

@PsiACE PsiACE left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #3921 (a73f927) into main (9c99b0a) will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3921   +/-   ##
=====================================
- Coverage     56%     56%   -1%     
=====================================
  Files        800     800           
  Lines      42754   42754           
=====================================
- Hits       24348   24343    -5     
- Misses     18406   18411    +5     
Impacted Files Coverage Δ
common/dal/src/context.rs 81% <0%> (-3%) ⬇️
common/management/src/cluster/cluster_mgr.rs 78% <0%> (-2%) ⬇️
common/meta/sled-store/src/sled_tree.rs 86% <0%> (-2%) ⬇️
common/containers/src/pool.rs 85% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c99b0a...a73f927. Read the comment docs.

@bohutang

Copy link
Copy Markdown
Member

@TennyZhuang Thank you!

@bohutang
bohutang merged commit 2eb344e into databendlabs:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants