Skip to content

STORAGE: Refine the storage engine descriptor#4061

Merged
bohutang merged 2 commits into
databendlabs:mainfrom
bohutang:dev-storage-desc
Feb 6, 2022
Merged

STORAGE: Refine the storage engine descriptor#4061
bohutang merged 2 commits into
databendlabs:mainfrom
bohutang:dev-storage-desc

Conversation

@bohutang

@bohutang bohutang commented Feb 6, 2022

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR:

  1. Refine the storage engine descriptor

Changelog

  • Improvement

Related Issues

Fixes #issue

Test Plan

Unit Tests

Stateless Tests

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel

vercel Bot commented Feb 6, 2022

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/94wcC67mnpfR3tt4UifeshwJwhRK
✅ Preview: Canceled

[Deployment for 0aed67b canceled]

@bohutang

bohutang commented Feb 6, 2022

Copy link
Copy Markdown
Member Author

cc @SGZW for review

@codecov-commenter

codecov-commenter commented Feb 6, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4061 (0aed67b) into main (c340c45) will decrease coverage by 0%.
The diff coverage is 85%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4061   +/-   ##
=====================================
- Coverage     57%     57%   -1%     
=====================================
  Files        825     825           
  Lines      43625   43628    +3     
=====================================
+ Hits       24935   24936    +1     
- Misses     18690   18692    +2     
Impacted Files Coverage Δ
query/src/catalogs/catalog.rs 29% <0%> (ø)
query/src/sql/statements/statement_show_engines.rs 0% <0%> (ø)
query/src/storages/storage_factory.rs 84% <85%> (+5%) ⬆️
query/src/catalogs/impls/database_catalog.rs 77% <100%> (ø)
query/src/catalogs/impls/mutable_catalog.rs 73% <100%> (ø)
query/src/storages/fuse/table.rs 93% <100%> (ø)
query/src/storages/github/github_table.rs 8% <100%> (ø)
query/src/storages/memory/memory_table.rs 96% <100%> (ø)
query/src/storages/null/null_table.rs 90% <100%> (ø)
common/containers/src/pool.rs 77% <0%> (-3%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c340c45...0aed67b. Read the comment docs.

@bohutang

bohutang commented Feb 6, 2022

Copy link
Copy Markdown
Member Author

Let's merge!

@bohutang
bohutang merged commit 4985af2 into databendlabs:main Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants