Skip to content

feat(function): support length function for Array & Array<T>#5274

Merged
sundy-li merged 1 commit into
databendlabs:mainfrom
fkuner:feature-array-length
May 11, 2022
Merged

feat(function): support length function for Array & Array<T>#5274
sundy-li merged 1 commit into
databendlabs:mainfrom
fkuner:feature-array-length

Conversation

@fkuner

@fkuner fkuner commented May 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

provide length function for Array & Array<T>

Changelog

  • New Feature
  • Build/Testing/CI

Related Issues

Fixes #5225

@fkuner
fkuner requested a review from bohutang as a code owner May 10, 2022 07:22
@vercel

vercel Bot commented May 10, 2022 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) May 10, 2022 at 0:39AM (UTC)

@databend-bot

databend-bot commented May 10, 2022

Copy link
Copy Markdown
Member

Take the reviewer to sundy-li @b41sh

@mergify

mergify Bot commented May 10, 2022

Copy link
Copy Markdown
Contributor

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify Bot added pr-feature this PR introduces a new feature to the codebase pr-build this PR changes build/testing/ci steps labels May 10, 2022
@fkuner

fkuner commented May 10, 2022

Copy link
Copy Markdown
Contributor Author

/help

@databend-bot

databend-bot commented May 10, 2022

Copy link
Copy Markdown
Member

/assignme -- assign the issue to you
/review @[username] -- take a reviewer for you
/help -- show help

@fkuner

fkuner commented May 10, 2022

Copy link
Copy Markdown
Contributor Author

/review @sundy-li

@databend-bot
databend-bot requested a review from sundy-li May 10, 2022 07:24
@databend-bot

databend-bot commented May 10, 2022

Copy link
Copy Markdown
Member

Take the reviewer to sundy-li

@databend-bot

databend-bot commented May 10, 2022

Copy link
Copy Markdown
Member

Take the reviewer to sundy-li @b41sh

@fkuner

fkuner commented May 10, 2022

Copy link
Copy Markdown
Contributor Author

/review @b41sh

@databend-bot
databend-bot requested a review from b41sh May 10, 2022 07:24
@databend-bot

databend-bot commented May 10, 2022

Copy link
Copy Markdown
Member

Take the reviewer to b41sh

sundy-li
sundy-li reviewed May 10, 2022
View reviewed changes
Comment thread common/functions/src/scalars/semi_structureds/array_length.rs Outdated
@fkuner
fkuner force-pushed the feature-array-length branch from 069a725 to 65da748 Compare May 10, 2022 09:41
b41sh
b41sh reviewed May 10, 2022
View reviewed changes
Comment thread common/functions/src/scalars/semi_structureds/length.rs
use crate::scalars::FunctionFeatures;

#[derive(Clone)]
pub struct VariantArrayLengthFunction {

@b41sh b41sh May 10, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name it as VariantLengthFunction is better, as Variant contains VariantArray type

@fkuner fkuner May 10, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I don't support the Variant except for VariantArray. It depends on whether we support it.

clickhouse's jsonLength

Comment thread common/functions/src/scalars/semi_structureds/length.rs
Comment thread tests/suites/0_stateless/02_function/02_0053_function_semi_structureds_array_length.sql Outdated
@fkuner
fkuner force-pushed the feature-array-length branch from 65da748 to b3ddecf Compare May 10, 2022 12:37
@sundy-li
sundy-li merged commit f070535 into databendlabs:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@b41sh b41sh b41sh left review comments
@sundy-li sundy-li sundy-li approved these changes
@bohutang bohutang Awaiting requested review from bohutang

Assignees

No one assigned

Labels

pr-build this PR changes build/testing/ci steps pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: length function should work with Array & Array<T> columns

4 participants

@fkuner @databend-bot @b41sh @sundy-li